Tagged hills vanishing

[nigheandonn]

The two tagged hills have vanished three times now from https://www.walkhighlands.co.uk/Forum/viewtopic.php?f=16&t=96784

First they had gone from the draft, which happens quite often, so I just put them back in before I posted it, but then when I looked later last night there were no hills listed. I thought maybe the posting had just gone wrong - I wrote on the computer and then proofread on my tablet, so might have had two versions - and edited it, but this morning they were gone again, and I know I saw them there last night!

I put them back in again, which might have been a bad idea - do you want me to wait and let you know if they vanish for a fourth time?

[nigheandonn]

I think I've established - after it happened in another draft - that they're vanishing when I save a draft, or edit and resubmit a report, which is better than if they were just vanishing while I wasn't looking.

Possibly WH just isn't expecting people to submit reports from 6 year old drafts, and they've got worn out somehow!

[BlackPanther]

I noticed this bug, too. Basically, every time I save a draft, all tagged hills disappear and have to be re-tagged before posting the report.

[Paul Webster]

Sorry about this. I have been looking into it with regards to changing this. The mountain and route tags on walk reports are stored against the topic in the topic table in our database. Unfortunately, drafts are not in the topic table at all - they are stored elsewhere. This means that coming up with a way of saving the mountains tagged as part of a draft would be quite involved.

At the moment, I think we'd have to say this was a 'feature' - best not to fill in the hills climbed etc. if planning to save as a draft rather than submit, and to do it when you are ready to post the report.

I've added a message about this when saving a draft.

[nigheandonn]

Thank you for looking into it - the hills do seem to have stopped vanishing when making an edit, which was the most disconcerting thing, so maybe that was just something gone wrong with that post somehow. I can live with them vanishing from drafts!

[BlackPanther]

Thanks for clarifying it, Paul. We can live with this small issue

BTW I noticed that hills tagged disappear also every time I click "preview" on unsaved report, which I guess is a part of the same problem.

[Paul Webster]

Thank you for looking into it - the hills do seem to have stopped vanishing when making an edit, which was the most disconcerting thing,

They shouldn't vanish when you edit. However, if you select to tag your report to a walk route, all the hills are reset to the ones included in that walk route. So if you tag the route first, the hills will be filled for you; but if you tag some hills and then choose a walk route (that doesn't include those hills), then the ones you tagged will be overwritten, if that makes sense.

I'll look into the loss when previewing, may be able to do something about that.

[nigheandonn]

It definitely wasn't that, because it was one of my Pennine Way reports, where you don't have any routes

But I'm quite willing to believe that it was because the original drafts were more than 6 years old and had just got worn out!

[Paul Webster]

OK, been through the code and found a couple of bugs that meant some hills (but not all) would vanish if you edited a report, or previewed it, sorry.

Both those issues should now be resolved.

Tagged hills are still not saved along with drafts though (so don't bother to tag until ready to post)

[nigheandonn]

How confusing

Thanks for the time you've spent on this!